|
Editor indentation performs reindentation and code beautification of Swing document.
Question (arch-overall): Describe the overall architecture. Answer:
Editor Indentation module defines
EditorIndentationAPI
providing indentation and reformatting services to the clients.
It also contains SPI allowing the modules to register language-specific
indenters and formatters into
MimeLookup
through XML layers.
Altghough there are formatting actions already there may be clients wishing to explicitly fix indentation of e.g. a newly inserted code into a Swing document.
The same code is used after inserting a newline into a document.
The Indent is an entry point for performing reindentation. The following code should be used by clients:Indent indent = Indent.get(doc); indent.lock(); try { doc.atomicLock(); try { indent.reindent(startOffset, endOffset); } finally { doc.atomicUnlock(); } } finally { indent.unlock(); }
Code beautification should not only fix line indentation but it may also perform extra changes to code according to formatting rules. For example add newlines or additional whitespace or add/remove extra braces etc.
The Reformat class should be used:Reformat reformat = Reformat.get(doc); reformat.lock(); try { doc.atomicLock(); try { reformat.reformat(startOffset, endOffset); } finally { doc.atomicUnlock(); } } finally { reformat.unlock(); }Question (arch-time): What are the time estimates of the work? Answer:
Available for NetBeans 6.0.
Question (arch-quality): How will the quality of your code be tested and how are future regressions going to be prevented? Answer:Unit tests are provided for checking correctness of infrastructure and delegation from the legacy editor actions to the new API.
Question (arch-where): Where one can find sources for your module? Answer:
The sources for the module are in the Apache Git repositories or in the GitHub repositories.
These modules are required in project.xml:
None.
Question (dep-platform): On which platforms does your module run? Does it run in the same way on each? Answer:All platforms.
Question (dep-jre): Which version of JRE do you need (1.2, 1.3, 1.4, etc.)? Answer:JRE 1.5.
Question (dep-jrejdk): Do you require the JDK or is the JRE enough? Answer:JRE is enough.
Jar only.
Question (deploy-nbm): Can you deploy an NBM via the Update Center? Answer:Yes.
Question (deploy-shared): Do you need to be installed in the shared location only, or in the user directory only, or can your module be installed anywhere? Answer:Anywhere.
Question (deploy-packages): Are packages of your module made inaccessible by not declaring them public? Answer:Only API and SPI packages are public.
Question (deploy-dependencies): What do other modules need to do to declare a dependency on this one, in addition to or instead of the normal module dependency declaration (e.g. tokens to require)? Answer:Nothing.
Yes.
Question (compat-standards): Does the module implement or define any standards? Is the implementation exact or does it deviate somehow? Answer:No.
Question (compat-version): Can your module coexist with earlier and future versions of itself? Can you correctly read all old settings? Will future versions be able to read your current settings? Can you read or politely ignore settings stored by a future version? Answer:Yes.
Question (compat-deprecation): How the introduction of your project influences functionality provided by previous version of the product? Answer:
The new API can coexist with the old formatting APIs (eg. org.openide.text.IndentEngine
and org.netbeans.editor.Formatter
). However, all clients are encouraged
to update their modules and use this new API.
java.io.File
directly?
Answer:
No.
Question (resources-layer): Does your module provide own layer? Does it create any files or folders in it? What it is trying to communicate by that and with which components? Answer:No.
Question (resources-read): Does your module read any resources from layers? For what purpose? Answer:Not directly. Only through MimeLookup.
Question (resources-mask): Does your module mask/hide/override any resources provided by other modules in their layers? Answer:No.
Question (resources-preferences): Does your module uses preferences via Preferences API? Does your module use NbPreferences or or regular JDK Preferences ? Does it read, write or both ? Does it share preferences with other modules ? If so, then why ? Answer:No.
org.openide.util.Lookup
or any similar technology to find any components to communicate with? Which ones?
Answer:
It uses MimeLookup to search for registered indentation and reformatting task factories.
Question (lookup-register): Do you register anything into lookup for other code to find? Answer:
The module registers org.netbeans.modules.editor.lib.FormatterOverride
implementation so that it gets callback-ed from Editor Library formatter's infrastructure.
No.
System.getProperty
) property?
On a similar note, is there something interesting that you
pass to java.util.logging.Logger
? Or do you observe
what others log?
Answer:
No.
Question (exec-component): Is execution of your code influenced by any (string) property of any of your components? Answer:No.
Question (exec-ant-tasks): Do you define or register any ant tasks that other can use? Answer:No.
Question (exec-classloader): Does your code create its own class loader(s)? Answer:No.
Question (exec-reflection): Does your code use Java Reflection to execute other code? Answer:No.
Question (exec-privateaccess): Are you aware of any other parts of the system calling some of your methods by reflection? Answer:No.
Question (exec-process): Do you execute an external process from your module? How do you ensure that the result is the same on different platforms? Do you parse output? Do you depend on result code? Answer:No.
Question (exec-introspection): Does your module use any kind of runtime type information (instanceof
,
work with java.lang.Class
, etc.)?
Answer:
No.
Question (exec-threading): What threading models, if any, does your module adhere to? How the project behaves with respect to threading? Answer:Both reindentation and reformatting are executed synchronously in a thread that calls the API classes (typically AWT thread).
Question (security-policy): Does your functionality require modifications to the standard policy file? Answer:No.
Question (security-grant): Does your code grant additional rights to some other code? Answer:No.
None.
Question (format-dnd): Which protocols (if any) does your code understand during Drag & Drop? Answer:None.
Question (format-clipboard): Which data flavors (if any) does your code read from or insert to the clipboard (by access to clipboard on means calling methods onjava.awt.datatransfer.Transferable
?
Answer:
None.
No.
Question (perf-exit): Does your module run any code on exit? Answer:No.
Question (perf-scale): Which external criteria influence the performance of your program (size of file in editor, number of files in menu, in source directory, etc.) and how well your code scales? Answer:Size of the code block being reformatted and complexity of the reformatters.
Question (perf-limit): Are there any hard-coded or practical limits in the number or size of elements your code can handle? Answer:No.
Question (perf-mem): How much memory does your component consume? Estimate with a relation to the number of windows, etc. Answer:No significant memory consumption. Only line indent strings are reasonably cached.
Question (perf-wakeup): Does any piece of your code wake up periodically and do something even when the system is otherwise idle (no user interaction)? Answer:No.
Question (perf-progress): Does your module execute any long-running tasks? Answer:
Reformatting or reindentation of a large block of text can be time-consuming.
The API is however not tied to be called in AWT thread only so the caller may reschedule
the processing into another thread. It should ensure that the user won't be typing
(or otherwise modifying) the document being reformatted.
No.
Question (perf-menus): Does your module use dynamically updated context menus, or context-sensitive actions with complicated and slow enablement logic? Answer:No.
Question (perf-spi): How the performance of the plugged in code will be enforced? Answer:The plugged in code should control its complexity. The indentation infrastructure may provide a logger for displaying of the time spent in the reformatting and reindenting tasks.